Add Core Profile 11 Runner for Glassfish Embedded Web #25446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having this file in the Uber jar was marking it as a bean archive and causing conflicts with the CDI Extensions adding the beans programatically
OndroMih
reviewed
May 23, 2025
|
Hi, @Thihup, this PR now passes the usual Jenkins CI. That doesn't run the Core TCK though. What's the status? Does this runner run all the Core Profile TCKs? Do all tests pass? |
|
We have two Java files changes about a report, and the rest of the files is the usual copy of the ones in the platform-tck. We may think about whether we want to continuously copy these files, or just let them be at the platform-tck? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.